Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/AB#72584_reflect-dashboard-changes-on-templates #963

Open
wants to merge 3 commits into
base: 2.x.x
Choose a base branch
from
Open

feat/AB#72584_reflect-dashboard-changes-on-templates #963

wants to merge 3 commits into from

Conversation

matheus-relief
Copy link
Collaborator

@matheus-relief matheus-relief commented Jan 31, 2024 •
edited

Description

This PR makes it so changes in the "main dashboards" are reflected in any templates that inherit it, unless the widgets has been modified in the template previously

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

See below

Screenshots

2024-01-31.00-23-55.1.online-video-cutter.com.mp4

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@matheus-relief matheus-relief added the enhancement Existing feature label Jan 31, 2024
@matheus-relief matheus-relief requested a review from a team January 31, 2024 04:06
@matheus-relief matheus-relief self-assigned this Jan 31, 2024
@matheus-relief matheus-relief mentioned this pull request Jan 31, 2024
Open
19 tasks
@NathanHGit NathanHGit requested review from NathanHGit and removed request for a team February 1, 2024 09:37
NathanHGit
NathanHGit approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@NathanHGit NathanHGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine according to the PR description. I didn't find any bugs while testing and the code looks good as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanHGit NathanHGit NathanHGit approved these changes

Assignees

@matheus-relief matheus-relief

Labels
enhancement Existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matheus-relief @NathanHGit