Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to disable context change tracking #2293

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

Adlai-Holler
Copy link
Contributor

This was motivated by an app I'm working on where I always save through the main queue context, and Core Data is crashing me whenever I try to merge changes up from the persistence context, which I don't need to do anyway.

@segiddins
Copy link
Member

Needs tests?

@Adlai-Holler
Copy link
Contributor Author

@segiddins Could you take a look at something for me? testThatChangesGetMergedFromPersistenceContextWhenTheyShould is failing, because when the RKManagedObjectContextChangeMergingObserver goes to merge changes, it looks at its internal objectIDsFromChildDidSaveNotification and decides Skipping merge of NSManagedObjectContextDidSaveNotification: the save event originated from the mergeContext and thus no save is necessary. Not sure I understand the logic around objectIDsFromChildDidSaveNotification.

@tengelmeier
Copy link

The crash is probably related to #2333 - As I didn't find an algorithm to fix the problem I ended up with an derived RKMangedObjectStore where during various RK operations the merging gets disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants