Resolving RKObjectRequestOperation not releasing.
#2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dereferences strong reference to http operation. Fixes RestKit#2399 Reverting changes previously lost at #c6b5d159c20f81de1df1a699fd6cb850b99cd3d9
|
We're having major issues with this same problem and this PR fixes it. What would it take to get this merged? |
|
Please add test coverage 👍 |
| objc_setAssociatedObject(operation, RKParentObjectRequestOperation, nil, OBJC_ASSOCIATION_RETAIN_NONATOMIC); | ||
| if (parentOperation) { | ||
| objc_setAssociatedObject(operation, RKOperationFinishDate, [NSDate date], OBJC_ASSOCIATION_RETAIN_NONATOMIC); | ||
| return; |
There was a problem hiding this comment.
this return statement is not needed
blackm00n
pushed a commit
to blackm00n/RestKit
that referenced
this pull request
Sep 9, 2016
trobrock
added a commit
to greenbits/RestKit
that referenced
this pull request
Jun 29, 2018
trobrock
added a commit
to greenbits/RestKit
that referenced
this pull request
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dereferences strong reference to http operation.
Fixes #2399
Reverting changes previously lost at #c6b5d159c20f81de1df1a699fd6cb850b99cd3d9