Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced dynamic mapping #2402

Open
wants to merge 39 commits into
base: development
Choose a base branch
from
Open

Enhanced dynamic mapping #2402

wants to merge 39 commits into from

Conversation

Brain89
Copy link

@Brain89 Brain89 commented Mar 16, 2016

Hey,

I've added enhanced dynamic mapping. Now you can conditionally check fileds also from parent object presentation.

@segiddins
Copy link
Member

This is missing test coverage

@valeriomazzeo
Copy link
Member

@Brain89 could you please update your branch and add test coverage?

stnslw and others added 10 commits July 4, 2017 14:17
Shouldn’t validate content type if there is no content
…2516)

* Changed the `RKStringTokenizer` method `- (NSSet *)tokenize:(NSString *)string` to use `kCFStringTokenizerUnitWordBoundary` instead of `kCFStringTokenizerUnitWord`. This then allows tokens to be created for symbols such as '@', '$' and '#' and therefore making them searchable.

As a result of using `kCFStringTokenizerUnitWordBoundary` instead of `kCFStringTokenizerUnitWord`, spaces are detected and a token created. As we don't want to be returning results that include a space, this token (if it exists) is removed before the tokens are returned.

Unit tests added to cover both the creating of tokens from strings that contain symbols and searching for managed objects that contain symbols.

* Core formatting - removed tabs from empty lines in RKStringTokenizer.

* Fixed assert mistake in RKSearchTest unit test `testSearchingForManagedObjectsWithSymbols`.
@Brain89
Copy link
Author

Brain89 commented Sep 8, 2017

Hi, I have pulled current development branch and added tests for RKDynamicMapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants