Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse transformer introspection #2475

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

rafaelnobrepd
Copy link

This should close #1949 , I had the same issue and was upset for not being able to register a custom transformer globally because of the documented lack of ability to infer types on inverse mappings (because of NSMutableDictionary objectClass)
The implementation is roughly the same as #2095 , only during the inverse mapping construction, introspecting on the original mapping's objectClass.

I tried running the existing development test suite before hand to verify my implementation wouldn't break any of them, but it had hundreds of failing tests right after cloning so I couldn't. It has been working on my own app, appreciate feedback of anything that this might unadvertly break.

@segiddins
Copy link
Member

This will require test coverage to merge, thanks!

@valeriomazzeo
Copy link
Member

@rafaelnobrepd would you be able to provide test coverage?

@rafaelnobrepd
Copy link
Author

Hi, I actually took a quick look at this today, as it should be easy to add test coverage covering my own usage cases, but I realized it is breaking testInverseMappingWithNilDestinationKeyPathForAttributeMapping which was added when addressing #1116 . I would need some help understanding it to be able to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value transformers are not applied on POST body data
3 participants