#2502 Fix CoreData concurrency issues in RKManagedObjectRequestOperation & RKManagedObjectResponseMapperOperation #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2017 13:25
…ectRequestOperation to accommodate for CoreData concurrencty
|
@rubnov could you please update from Also, a unit test that reproduces the problem that has been fixed would be greatly appreciated. |
updated travis file to spin an xcode8 image
since xcode8 clean action is not supported
separated linting and tests into two scripts so we can use travis_wait and still have some output during the build fixed bundler cache
|
@valeriomazzeo done. Didn't have time to write specific unit tests to the fixes I've made though. I doubt I'll get to it any time soon. Sorry. |
…estKit#2516) * Changed the `RKStringTokenizer` method `- (NSSet *)tokenize:(NSString *)string` to use `kCFStringTokenizerUnitWordBoundary` instead of `kCFStringTokenizerUnitWord`. This then allows tokens to be created for symbols such as '@', '$' and '#' and therefore making them searchable. As a result of using `kCFStringTokenizerUnitWordBoundary` instead of `kCFStringTokenizerUnitWord`, spaces are detected and a token created. As we don't want to be returning results that include a space, this token (if it exists) is removed before the tokens are returned. Unit tests added to cover both the creating of tokens from strings that contain symbols and searching for managed objects that contain symbols. * Core formatting - removed tabs from empty lines in RKStringTokenizer. * Fixed assert mistake in RKSearchTest unit test `testSearchingForManagedObjectsWithSymbols`.
To fix Xcode 9 "The block declaration is not a prototype" warning
Change "to to" to "to"
…pletion block of the 'setImageWithURLRequest:placeholderImage:success:failure:' method on the AFNetworking UIImageView extension.
…s. The test is still failing at this point since I haven't yet fixed the bug.
…ImageWithURLRequest:placeholderImage:success:failure:' wasn't being returned in the 'success' completion block when the image was fetched from the cache. The unit test is passing now.
…d tests for the rest of the parameters in the 'success' block.
…working library's implementation of the UIImageView helper category for setting an image from a URL. This will be a breaking change, but should help make people aware of potential unwanted behavior if their project includes both AFNetworking and RestKit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.