Retain cycle fix between a parent NSOperation and the entity deletion operation #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* development: - ios 12 crash entity is not visible to managedObject context fixed typo Fixed xcode 9 warnings Add test that represents the issue Perform access to NSManagedObjectContext's properties only on its queue Fixes RestKit#2531. Fixed namespace collision with the official AFNetworking library's implementation of the UIImageView helper category for setting an image from a URL. This will be a breaking change, but should help make people aware of potential unwanted behavior if their project includes both AFNetworking and RestKit. Support for previous commit. Extra bonus for RestKit#2529. Implemented tests for the rest of the parameters in the 'success' block. Fixes RestKit#2529. Fixed bug where the NSURLRequest passed into 'setImageWithURLRequest:placeholderImage:success:failure:' wasn't being returned in the 'success' completion block when the image was fetched from the cache. The unit test is passing now. Adopted library testing syntax and stubbed out a couple of extra tests. The test is still failing at this point since I haven't yet fixed the bug. Added unit test for making sure the URLRequest is returned in the completion block of the 'setImageWithURLRequest:placeholderImage:success:failure:' method on the AFNetworking UIImageView extension. Remove duplicate word in README Method signature update Changed RKStringTokenizer to allow tokenization of symbol characters (RestKit#2516)
* development: bump version 0.27.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a retain cycle when using tombstone deletion with a predicate. The parent operation strongly retains the deletion operation using associated objects, and the parent operation is added to the dependencies of the deletion operation so that the deletion operation only starts after the parent completes, which causes the deletion operation to strongly reference the parent as well.