Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types to better match reality. #122

Merged
merged 1 commit into from May 30, 2017
Merged

Update types to better match reality. #122

merged 1 commit into from May 30, 2017

Commits on May 30, 2017

  1. Update types to better match reality. 

    This also fixes an issue I discovered while figuring out what type `indentExclusionsRanges` was supposed to be. `MagicString#clone` does not appear to work when the object was constructed with a non-tuple. It seemed to expect an array of nodes – or something with `start` and `end` properties – but generated an array of tuples. Calling `#clone` multiple times no matter what the starting value would have resulted in an incorrect clone. I'm not 100% sure that I picked the right type, but this seemed the most consistent choice.
    @eventualbuddha
    eventualbuddha committed May 30, 2017
    Configuration menu
    Copy the full SHA
    1b169db View commit details
    Browse the repository at this point in the history