Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generateDecodedMap and expose SourceMap class #134

Merged
merged 1 commit into from Mar 15, 2018

Conversation

mourner
Copy link
Collaborator

@mourner mourner commented Mar 15, 2018

@Rich-Harris see rollup/rollup#2061 for motivation behind this change. It will make Rollup source map generation almost 2x faster.

  • Add MagicString/MagicStringBundle generateDecodedMap method, which returns a JSON representation of a source map (with array-form mappings).
  • Expose SourceMap class that accepts this form and creates a spec-compliant source map object.
  • Add corresponding TypeScript types.

P.S. Feel free to add me as a collaborator — I can triage some open issues/PRs.

@Rich-Harris Rich-Harris merged commit 49091db into Rich-Harris:master Mar 15, 2018
@mourner mourner deleted the generate-decoded-map branch March 15, 2018 12:47
@Rich-Harris
Copy link
Owner

🔥 you're on fire 🔥 updated the README and released 0.23.2. thanks! adding you as collab now

@mourner mourner mentioned this pull request Mar 15, 2018
@TrySound
Copy link
Collaborator

Awesome! This was one of the biggest performance issues in rollup. Thanks for your work, @mourner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants