Reduce memory overhead of sourcemapLocations #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was using an object to store positions in the string. This meant that those offsets were first stringified and then added as object properties. For a 200K JS code file (as parsed by rollup), the sourcemapLocations object was taking up 980K. Switching it to a BitSet that uses one bit per offset makes it take up 36K instead. Fixes Rich-Harris#167
|
Original memory use: Bit set memory use: (FWIW, using a vanilla |
|
@mihaip Thanks for profiling and putting this PR together. |
|
@mourner This PR is significant enough to warrant a new release. Thanks in advance. |
|
@mourner @Rich-Harris any thoughts on getting this merged? |
|
This is wonderful, thank you! Released 0.25.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was using an object to store positions in the string. This meant that those offsets were first stringified and then added as object properties. For a 200K JS code file (as parsed by rollup), the
sourcemapLocationsobject was taking up 980K. Switching it to aBitSet(contribution by @kzc) that uses one bit per offset makes it take up 36K instead.Fixes #167