Change contentOnly default to true

[benmccann]

This would fix vitejs/vite#7365.

To quote @dummdidumm on that issue:

The overwrite call removes all prepends/appends that were done on the start/end position if you don't pass in the { contentOnly: true } option as forth argument. I never came across a case where I would want the default behavior, so I'm always setting that option.

[dummdidumm]

This would be a breaking change, and considering the huge download numbers of magic-string, this should be clearly communicated if accepted.

[antfu]

Yeah, I feel the same. Since it won't actually block any usage, I would like to keep this thread open for a while longer to collect enough feedback from the community and only make this change if this is something most of us feel it's right to do.

[benmccann]

Yeah, the other alternative I had debated was making it required. That would fix the issue of people unknowingly using the default which mostly causes issues without it being a breaking change

[patak-dev]

Maybe there could be another method (supplant, or a better word?) with the default we want, and overwrite could be deprecated? Or a global config option to define the default of overwrite so we can continue to use the same name?

[benmccann]

Maybe there could be another method (supplant, or a better word?) with the default we want, and overwrite could be deprecated?

Yes, that's a much better solution. I've implemented that in #212