feat: fix .replace() when searching string, add .replaceAll()

README.md

@@ -165,9 +165,9 @@ Same as `s.appendLeft(...)`, except that the inserted content will go *before* a
 
 Same as `s.appendRight(...)`, except that the inserted content will go *before* any previous appends or prepends at `index`
 
-### s.replace( regexp, substitution )
+### s.replace( regexpOrString, substitution )
 
-String replacement with RegExp or string, a replacer function is also supported. Returns `this`.
+String replacement with RegExp or string. When using a RegExp, replacer function is also supported. Returns `this`.
 
 ```ts
 import MagicString from 'magic-string'

src/MagicString.js

@@ -736,7 +736,7 @@ export default class MagicString {
 		return this.original !== this.toString();
 	}
 
-	replace(searchValue, replacement) {
+	_replaceRegexp(searchValue, replacement) {
 		function getReplacement(match, str) {
 			if (typeof replacement === 'string') {
 				return replacement.replace(/\$(\$|&|\d+)/g, (_, i) => {
@@ -759,7 +759,7 @@ export default class MagicString {
 			}
 			return matches;
 		}
-		if (typeof searchValue !== 'string' && searchValue.global) {
+		if (searchValue.global) {
 			const matches = matchAll(searchValue, this.original);
 			matches.forEach((match) => {
 				if (match.index != null)
@@ -780,4 +780,25 @@ export default class MagicString {
 		}
 		return this;
 	}
+
+	_replaceString(string, replacement) {
+		const { original } = this;
+		const stringLength = string.length;
+		for (
+			let index = original.indexOf(string);
+			index !== -1;
+			index = original.indexOf(string, index + stringLength)
+		) {
+			this.overwrite(index, index + stringLength, replacement);
+		}
+
+		return this;
+	}
+
+	replace(searchValue, replacement) {
+		return this[typeof searchValue === 'string' ? '_replaceString' : '_replaceRegexp'](
+			searchValue,
+			replacement
+		);
+	}
 }

test/MagicString.js

@@ -1305,7 +1305,28 @@ describe('MagicString', () => {
 
 			s.replace('2', '3');
 
-			assert.strictEqual(s.toString(), '1 3 1 2');
+			assert.strictEqual(s.toString(), '1 3 1 3');
+		});
+
+		it('Should not treat string as regexp', () => {
+			assert.strictEqual(
+				new MagicString('1234').replace('.', '*').toString(),
+				'1234'
+			);
+		});
+
+		it('Should use substitution directly', () => {
+			assert.strictEqual(
+				new MagicString('11').replace('1', '$0$1').toString(),
+				'$0$1$0$1'
+			);
+		});
+
+		it('Should not search back', () => {
+			assert.strictEqual(
+				new MagicString('121212').replace('12', '21').toString(),
+				'212121'
+			);
 		});
 
 		it('works with global regex replace', () => {