Commits on May 13, 2016

1. FIX: slice considers intro/outro, no throw after removal …

   This fixes a few issues with slice introduced recently. Tests are added which fail before this patch.
   
   * slice now considers `intro` and `outro`: the recent change from `insert` to `insertLeft`/`insertRight` changed implementations to use `intro`/`outro` on a chunk, but slice wasn't updated to this new impl. Now, any `intro`/`outro` contained within the slice bounds is included in the result.
   
   * slice was broken if called after a `removed` or otherwise `edited` chunk: Because all chunks were being considered, regardless of if they overlapped the sliced range, a false-positive error was thrown indicating slicing a removed range. Now chunks which end before the sliced range are quickly skipped, removing the issue. As a bonus this adds a clarification of *which* bound was problematic.
   
   * slice was broken if chunks were moved such that chunks between the moved chunks would otherwise not be considered "included" in the slice range despite being between the start and end chunks.
   
   * performance of a slice of a small range suffers when in a large document: Previously all chunks were being considered, however the while loop can cease early as soon as a chunk is encountered which starts after the sliced range.
   
   * slice API behavior different slightly from Array#slice, that if a `start` is not provided, the empty string is provided, instead of the expected default `0` being used as `start`.

   

   leebyron committed May 13, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 7d280ef
   • Browse repository at this point

   Copy the full SHA

   7d280ef View commit details

   Browse the repository at this point in the history