Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change overwrite and remove to remove interior inserts #89

Merged
merged 1 commit into from Aug 12, 2016
Merged

Change overwrite and remove to remove interior inserts #89

merged 1 commit into from Aug 12, 2016

Commits on Jul 9, 2016

  1. Change overwrite and remove to remove interior inserts 

    This changes the `overwrite` and `remove` behavior to be consistent with `move`
and `slice`: the specified range includes any `insertRight`s on the left side
and any `insertLeft`s on the right side.

The code change ended up actually making the code simpler: `Chunk.edit` now
overwrites all chunk content, including the intro and outro, so the `overwrite`
code doesn't need to be careful about clearing the intro and outro for specific
chunks.

This fixes decaffeinate/decaffeinate#269 . See my
comment in that bug for an explanation of what was going wrong, and why this
case is important.

In addition to this passing all of the magic-string tests, I also ran all of the
decaffeinate tests with this change and they all pass. So at least with the
decaffeinate project, the code wasn't depending on the previous behavior.
    @alangpierce
    alangpierce committed Jul 9, 2016
    Configuration menu
    Copy the full SHA
    3f6dd4d View commit details
    Browse the repository at this point in the history