Extend the Error object with metadata #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary reason you'd want this is to allow catching the svg-parser errors with metadata attached. In my particular case I don't want my end users shown the message, I want to tell them they did something wrong and let _me_ handle PRs/Issues if the svg-parser turns out to be at fault (highly unlikely).
|
@Rich-Harris any chance we can merge this in? I'm happy to make changes, but I'd need your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary reason you'd want this is to allow catching the svg-parser errors with metadata attached.
In my particular case I don't want my end users shown the message (I carefully catch and rethrow errors with messages meant for end users if they do something irrecoverable).
I want to tell them they did something wrong and let me handle PRs/Issues if the svg-parser turns out to be at fault (highly unlikely).