AMQP: nack the message with requeue false when IgnoreWhenTaskNotRegistered #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RichardKnop Please review |
surendratiwari3
changed the title
|
@RichardKnop please check this also it's required bug fix. |
|
@RichardKnop Please check this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue related to the handling of AMQP based task messages when a task is not registered with the worker, and
IgnoreWhenTaskNotRegisteredis set. The existing logic is adjusted to correctly NACK the message withrequeue=falsein these scenarios.Changes Made
requeue=falsewhenIgnoreWhenTaskNotRegisteredis true.Impact
This fix ensures consistent and correct behavior in handling AMQP messages, especially in scenarios where tasks are not registered, and
IgnoreWhenTaskNotRegisteredis configured.