Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel dialog event listener & Export FeedbackService, FeedbackDirective #13

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

workfel
Copy link

@workfel workfel commented Nov 20, 2019

  • I need service to force re-render the screenshot, because before set screen image i need to hide all private user information.

@artar94
Copy link

artar94 commented Dec 23, 2019

@workfel I think it would be great to make another service specifically for export.
It should have only one method feedback(): Observable<Feedback>, which, if successful, returns Feedback, and if canceled, returns an error.
This will allow you to use this library with any buttons and directives, not just the built-in one, and it will not force the user to deal with the internal organization of the initScreenshotCanvas, setFeedback, openFeedbackDialog, etc. methods.

@workfel
Copy link
Author

workfel commented Dec 23, 2019

ok, but why don't juste export the current Service ?

@artar94
Copy link

artar94 commented Dec 23, 2019

I have nothing against it, but I would recommend at least renaming the current FeedbackService to FeedbackInternalService so that the new service has a user-friendly name.

@workfel
Copy link
Author

workfel commented Dec 23, 2019

Ok, i just updated the PR

spike008t and others added 29 commits December 14, 2020 16:30
WIP: Fix/angular 8 & 9 compat - bump 2.0.0
Looks like on es5 the string has a limit size of ~2Mb..
The image generated is cropped..
Fix/buffer size image & bump v2.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants