Playlist pagination #1010
Open
Playlist pagination #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playlist have been turned also into a ScrollableResultPages, and scrolling between playlist pages can be done via the usual Ctrl-u, Ctrl-d shortcuts. Also, deleting and following playlist is functional with this new system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pagination to playlists. Now playlist pages can be scrolled with usual ctrl+u, ctrl+d keys, so all playlist and not just the 50 first ones will be available.
I'm aware that the author was planning a change in the program's structure that will possibly make this pr useless in the future, but for me the app is quite unusable without all my playlists. Also, unsure if my code is quite rust-like, specifically at the new functions in
ScrollableResultPages, or inget_current_user_playlists, but it gets the job done for now. Listing playlists withspt list --playlistsstill return only the first playlist page.Let me tell you what you think about it. Thanks.