Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ripper for nsfwalbum.com #1691

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Ripper for nsfwalbum.com #1691

wants to merge 3 commits into from

Conversation

Issung
Copy link

@Issung Issung commented Jun 24, 2020

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

I've gone ahead and added a ripper for nsfwalbum.com.
They host their images on many different image hosting sites so you must replace part of the image urls to get the full image instead of the thumbnails.
There may be more hosts that I did not find, they can be added in later very easily.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

NOTES:
mvn test failed, i think it may because of how my maven is setup, it doesnt reference any files of ripme in the stacktrace, i can post the error if that is helpful.
I don't have any experience on how to do unit testing, I am eager to learn if someone wants to help and give me a quick run down.

@Issung
Copy link
Author

Issung commented Jun 24, 2020

It says the checks were not successful, this is my first pull request, can someone help me out here? From what I can gather the test failures aren't related to my contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant