Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negate expression #1692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Negate expression #1692

wants to merge 1 commit into from

Conversation

aeruower
Copy link

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (no bug report)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

It is clear from this commit diff that the changed if statement

if (cookieStr != "")

was incorrectly changed to

if (cookieStr.equals(""))

which should be

if (!cookieStr.equals(""))

instead.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@soloturn
Copy link
Contributor

this is already fixed in master, can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants