ripme downloading the -mobile.mp4 from redgifs/gfycat #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a dot in redgifs regex to account for them in usernames and search queries - Replaced fuzzyExists with better library efficient call that check the folder for existing file
- Added selfpost download functionality, currently it is fixed and cannot be disabled in the jar - Fixed Redgifs using mobile mp4 in its document and instead uses its api instead to fetch the hd version
- redgifs api blocking api calls so just replaced mobile string
soloturn
force-pushed
the
main
branch
2 times, most recently
from
48c77eb
to
41fc473
Compare
…e first page of the album is inputted
* EightmusesRipper fixed
soloturn
force-pushed
the
main
branch
5 times, most recently
from
e5e2033
to
9cdfe51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
Please make the ripper download the full quality mp4 from redgifs/gfycat, instead of the the -mobile.mp4. There's a fork of ripme here that does download the correct version. It was linked on another bug report of the mobile mp4 issue, here
Testing
Required verification:
mvn test(there are no new failures or errors) <--- not sure what this means, sorryThat fork of ripme does work for the -mobile mp4 issue, but it's as you can see quite a bit older (1.7.97 compared to your 2.0.1), so probably just want to take the bit that works and discard the rest, I guess.
Hope I did this pull request vaguely correctly man, I'm sorry if I messed it up, it's my first time doing this.