Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior of closing dialog with hitting X #1976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Attacktive
Copy link

#1975

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

I simply changed the behavior to close the dialog instead of terminating the application itself.

Technically, mvn test failed.

Boot Manifest-JAR contains absolute paths in classpath 'X:\WORKING\DIRECTORY\target\test-classes'
Hint: -Djdk.net.URLClassPath.disableClassPathURLCheck=true

But it doesn't seem relevant to my changes and did fail with the HEAD version, too.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@soloturn
Copy link
Contributor

merged here: https://github.com/ripmeapp2/ripme/releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ripper crashes when closing confirmation window
2 participants