Detection of circular references #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Sep 27, 2022
src/Reflection/ReflectionClass.php
Outdated
Comment on lines
1063
to
1085
| if ($this->cachedParentClassNames === null) { | ||
| $parentClassNames = []; | ||
|
|
||
| $parentClass = $this->getParentClass(); | ||
| while ($parentClass !== null) { | ||
| $parentClassName = $parentClass->getName(); | ||
|
|
||
| if ( | ||
| $this->name === $parentClassName | ||
| || in_array($parentClassName, $parentClassNames, true) | ||
| ) { | ||
| throw CircularReference::fromClassName($parentClassName); | ||
| } | ||
|
|
||
| $parentClassNames[] = $parentClassName; | ||
| $parentClass = $parentClass->getParentClass(); | ||
| } | ||
|
|
||
| $this->cachedParentClassNames = $parentClassNames; | ||
| } |
There was a problem hiding this comment.
Can we implement this check without having a mutable $this->cachedParentClassNames? Thinking of a by-ref parameter in a private method 🤔
There was a problem hiding this comment.
Is is such a problem? ReflectionClass already have some more caches...
There was a problem hiding this comment.
No, it's not, just trying to push the design for less stateful changes: can roll with the current solution too.
In practice, at some point, my aim is to have everything readonly :)
|
thank you for working on this! You beat me to opening a PR :) Looks like this will make it into 6.0, nice |
|
Nice. Maybe this is similar to the endless loop we see in phpstan/phpstan#8054 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1165