Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpunit/phpunit 10.1.0 and infection/infection to 0.26.20 #473

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

kukulich
Copy link
Contributor

No description provided.

@Ocramius Ocramius self-assigned this Apr 16, 2023
@Ocramius Ocramius added the enhancement New feature or request label Apr 16, 2023
@Ocramius Ocramius added this to the 1.30.0 milestone Apr 16, 2023
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kukulich!

@Ocramius Ocramius merged commit 23579f3 into Roave:1.30.x Apr 16, 2023
10 checks passed
@kukulich kukulich deleted the phpunit10.1 branch April 16, 2023 17:24
<testsuites>
<testsuite name="Roave\InfectionStaticAnalysis tests">
<directory>./test/unit</directory>
</testsuite>
</testsuites>

<coverage>
<coverage/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's not needed, as <source> is used by default. Or does it bring any other sense here? Would like to know as at Infection we just made an update related to this PHPUnit change, so if it has some meaning here, would like to understand what :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maks-rafalko I've used PHPUnit --migrate-configuration

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for letting me know, though not clear why it's done by migration script in his way 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants