Add possibility to permit specified targets only #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a regular expression to environment variable CORSANYWHERE_TARGET_WHITELIST to permit access to targets only.
Rob--W
reviewed
Aug 28, 2019
| @@ -364,6 +365,12 @@ function getHandler(options, proxy) { | |||
| return; | |||
| } | |||
|
|
|||
| if (corsAnywhere.checkTargetWhitelisted && !corsAnywhere.checkTargetWhitelisted(location)) { | |||
There was a problem hiding this comment.
This is not the right place to enforce target restrictions, because it does not account for redirects.
I once started with a patch to limit targets, in #78, but never finished it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the project should be named cors-somewhere then, but it can be used in production environment without the risk of having a proxy to sites I do not permit.