Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add focal to travis, and debian stretch / buster to Github action to catch errors like Error:SSL routines:SSL_CTX_use_certificate:ee key too small #271

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MaxPeal
Copy link

@MaxPeal MaxPeal commented Sep 5, 2020

to catch bugs like Error:SSL routines:SSL_CTX_use_certificate:ee key too small

https://wiki.debian.org/ContinuousIntegration/TriagingTips/openssl-1.1.1

@coveralls
Copy link

coveralls commented Sep 5, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling d651a62 on MaxPeal:patch-1 into a0309e6 on Rob--W:master.

@Rob--W
Copy link
Owner

Rob--W commented Sep 9, 2020

What errors did you catch by enabling this option? The tests are supposedly independent of the underlying TLS library.

@MaxPeal
Copy link
Author

MaxPeal commented Sep 11, 2020

please see the error of the github action,
the tests are not independent of the underlying TLS library.
on debian stretch its tests ok,
https://github.com/MaxPeal/cors-anywhere/runs/1099395503?check_suite_focus=true
https://github.com/MaxPeal/cors-anywhere/actions?query=workflow%3ADocker-Image-CI-stretch

on debian buster it FAIL
https://github.com/MaxPeal/cors-anywhere/actions/runs/248959691
https://github.com/MaxPeal/cors-anywhere/actions?query=workflow%3ADocker-Image-CI-buster

my PR with out github action dont work, PR for RfC #273

@MaxPeal
Copy link
Author

MaxPeal commented Sep 11, 2020

the ERROR MSG:
100 passing (5s)
2 failing

  1. server on https "before all" hook:
    Error: error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key too small
    at Object.createSecureContext (_tls_common.js:129:17)
    at Server.setSecureContext (_tls_wrap.js:1323:27)
    at Server (_tls_wrap.js:1181:8)
    at new Server (https.js:66:14)
    at Object.createServer (https.js:90:10)
    at createServer (lib/cors-anywhere.js:417:31)
    at Context. (test/test.js:500:21)
    at processImmediate (internal/timers.js:461:21)

  2. server on https "after all" hook:
    TypeError: Cannot read property 'close' of null
    at stopServer (test/test.js:35:17)
    at Context. (test/test.js:517:5)
    at processImmediate (internal/timers.js:461:21)

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! cors-anywhere@0.4.3 test: mocha ./test/test*.js --reporter spec
npm ERR! Exit status 2
npm ERR!

@MaxPeal MaxPeal changed the title add focal to travis to catch errors on newer linux add focal to travis, and debian stretch / buster to Github action to catch errors like Error:SSL routines:SSL_CTX_use_certificate:ee key too small Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants