Update dependencies Replacing Istanbul with NYC #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing Istanbul with NYC
Rob--W
requested changes
Jun 21, 2021
package.json
Outdated
| }, | ||
| "scripts": { | ||
| "lint": "eslint .", | ||
| "test": "mocha ./test/test*.js --reporter spec", | ||
| "test-coverage": "istanbul cover ./node_modules/.bin/_mocha -- test/test.js test/test-ratelimit.js --reporter spec" | ||
| "test-coverage": "nyc npm run test" |
There was a problem hiding this comment.
This is different from before - previously I explicitly listed the tests of interest to exclude test-memory.js, which basically runs a simple test repeatedly.
There was a problem hiding this comment.
Now I understand. I’ve correct that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dependencies that have known vulnerabilities.
Replacing Istanbul with NYC since the former is deprecated.