Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for .npmrc noproxy #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefdev49
Copy link

Add support for 'noproxy' from .npmrc (https://docs.npmjs.com/cli/v9/using-npm/config#noproxy)
and have it takes precedence over no_proxy in .npmrc.

noproxy is npm's documented way of specifying non proxied hosts and domains.

@ksathyanm
Copy link

@Rob--W ping

@ksathyanm
Copy link

@Rob--W axios user here. Looking for noproxy support for npm v9. Can you please take a look at this PR?

@Rob--W
Copy link
Owner

Rob--W commented Apr 15, 2023

I have looked into this, and it appears that no_proxy was renamed to noproxy in npm/cli#46 in response to the feedback that the --no-proxy option was not working as expected at https://web.archive.org/web/20211028044200/https://npm.community/t/no-proxy-missing-from-npm-cli/1327.html .

I'll re-examine the addition from #9, update the library if needed + document the npm config variables as appropriate.

@Rob--W
Copy link
Owner

Rob--W commented Apr 16, 2023

As part of maintenance, I'm going to carefully examine the set of changes, and then publish 1.2.0 or even 2.0.0.

The proposed change here has potential to cause breakage, e.g. as seen in #13 after support for npmrc was introduced in #9.

As one of the first steps, I'm going to update the CI in #20.

Due to other obligations I cannot work on this before next month (May).

@ricksbrown
Copy link

This PR would help with this issue: cypress-io/cypress#19586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants