Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: E2EE thread main message reactivity #32381

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented May 7, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

E2EE-16

Copy link
Contributor

dionisio-bot bot commented May 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: d967b15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.56%. Comparing base (49f8547) to head (d967b15).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32381      +/-   ##
===========================================
+ Coverage    55.53%   55.56%   +0.03%     
===========================================
  Files         2401     2403       +2     
  Lines        52855    52865      +10     
  Branches     10854    10857       +3     
===========================================
+ Hits         29353    29377      +24     
+ Misses       20898    20884      -14     
  Partials      2604     2604              
Flag Coverage Δ
e2e 54.86% <100.00%> (+0.07%) ⬆️
unit 73.48% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review May 20, 2024 16:30
@yash-rajpal yash-rajpal requested a review from a team as a code owner May 20, 2024 16:30
@yash-rajpal yash-rajpal added this to the 6.9 milestone May 20, 2024
@scuciatto scuciatto removed this from the 6.9 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants