Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new navigation with NavBar #32382

Draft
wants to merge 37 commits into
base: develop
Choose a base branch
from
Draft

feat: new navigation with NavBar #32382

wants to merge 37 commits into from

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 7, 2024

SIDE-35

epic tasks:

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 6df5295

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 71.07438% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 51.57%. Comparing base (526cbf1) to head (6df5295).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32382      +/-   ##
===========================================
- Coverage    56.22%   51.57%   -4.66%     
===========================================
  Files         2425     2155     -270     
  Lines        53517    48555    -4962     
  Branches     11023     9918    -1105     
===========================================
- Hits         30092    25040    -5052     
- Misses       20832    21246     +414     
+ Partials      2593     2269     -324     
Flag Coverage Δ
e2e 46.29% <70.71%> (-9.60%) ⬇️
unit 73.11% <86.20%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant