Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Users in role table not rendering all states properly #32412

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented May 10, 2024

Proposed changes (including videos or screenshots)

Depends on: #32320

It renders the error and empty state on the table instead of a wrong toast message when not finding users in role.
Also adds the proper fields validation

Issue(s)

Steps to test or reproduce

Further comments

CORE-465

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 3b06b2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented May 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 84.09091% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 56.00%. Comparing base (c6450b1) to head (3b06b2b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32412      +/-   ##
===========================================
- Coverage    56.22%   56.00%   -0.23%     
===========================================
  Files         2425     2424       -1     
  Lines        53522    53467      -55     
  Branches     11024    11019       -5     
===========================================
- Hits         30093    29944     -149     
- Misses       20806    20883      +77     
- Partials      2623     2640      +17     
Flag Coverage Δ
e2e 55.89% <84.09%> (+<0.01%) ⬆️
unit 72.32% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the title fix: Users in role list not rendering properly fix: Users in role table not rendering properly May 10, 2024
@dougfabris dougfabris added this to the 6.9 milestone May 16, 2024
@dougfabris dougfabris marked this pull request as ready for review May 16, 2024 22:06
@dougfabris dougfabris requested a review from a team as a code owner May 16, 2024 22:06
@dougfabris dougfabris modified the milestones: 6.9, 6.10 May 21, 2024
@dougfabris dougfabris changed the title fix: Users in role table not rendering properly fix: Users in role table not rendering all states properly May 23, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add tests to cover the problems mentioned in the PR description? Create tests throwing error and the empty state, and make sure it shows the toast...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants