Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Markdown breaking issue between hyperlinks #1260

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Giridharan002
Copy link

Proposed changes (including videos or screenshots)

This pull request addresses an issue where typing between two hyperlinks in Rocket.Chat causes the markdown to break. This happens even without a space or other separator between the hyperlinks and the inserted text.
properly converts:
[Rocket.Chat] [New release](https://www.rocket.chat/blog/new-starter-pro-plans) to html like this <p>[Rocket.Chat] <a href="https://www.rocket.chat/blog/new-starter-pro-plans">New release</a></p>

Issues

closes the issue:
RocketChat/Rocket.Chat#31766
RocketChat/Rocket.Chat#31418

Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: 4bfc923

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Giridharan002
Copy link
Author

@dougfabris, could you please take a moment to review the PR when you're available, Thank you!

@Giridharan002
Copy link
Author

@MartinSchoeler could you please review the PR if you have some time, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants