Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pnpm #3267

Closed
jpveooys opened this issue May 3, 2022 · 5 comments · Fixed by #3775
Closed

Migrate to pnpm #3267

jpveooys opened this issue May 3, 2022 · 5 comments · Fixed by #3775
Assignees
@m7kvqbe1
Labels
Size: Medium Assessed as medium task Type: Dependencies Issues that relate to a dependency Type: Techdebt Requires or will require rework
Projects
Tactical Board

Comments

@jpveooys
Copy link
Contributor

jpveooys commented May 3, 2022 •
edited

Following #2716 we decided that we should migrate from yarn v1 to npm v8.

There are currently two external issues blocking this:

A chunk of the work has already been done on this branch: https://github.com/defencedigital/mod-uk-design-system/tree/spike/npm-v8-2
@jpveooys jpveooys added Type: Techdebt Requires or will require rework Type: Dependencies Issues that relate to a dependency Status: Blocked Unable to progress currently due to internal/external blocker Size: Medium Assessed as medium task labels May 3, 2022
@ahwcikxz ahwcikxz added this to Candidates for Ready in Tactical Board May 3, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Jul 4, 2022
@jpveooys
Copy link
Contributor Author

As yet, the linked npm issue remains unresolved. pnpm is an alternative that could be investigated.

@jpveooys jpveooys changed the title Migrate to npm v8 Migrate to pnpm Sep 23, 2022
@jpveooys jpveooys moved this from Candidates for Ready to In Progress in Tactical Board Sep 23, 2022
@jpveooys jpveooys self-assigned this Sep 23, 2022
@jpveooys
Copy link
Contributor Author

Unfortunately, using pnpm is also blocked, as Dependabot does not support it:

Some initial work on using pnpm is on this branch:

https://github.com/defencedigital/mod-uk-design-system/pull/new/chore/pnpm

@jpveooys jpveooys moved this from In Progress to Candidates for Ready in Tactical Board Sep 23, 2022
@github-actions github-actions bot removed the Status: Stale Issue with no activity for the past 60 days label Sep 26, 2022
@jpveooys jpveooys changed the title Migrate to pnpm Migrate to pnpm or npm Sep 28, 2022
@github-actions
Copy link

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Nov 28, 2022
@markhigham markhigham removed the Status: Stale Issue with no activity for the past 60 days label Apr 5, 2024
@markhigham
Copy link
Collaborator

pnpm

@markhigham markhigham changed the title Migrate to pnpm or npm Migrate to pnpm Apr 5, 2024
@m7kvqbe1 m7kvqbe1 moved this from Candidates for Ready to Ready in Tactical Board Apr 17, 2024
@m7kvqbe1 m7kvqbe1 assigned m7kvqbe1 and unassigned jpveooys Apr 18, 2024
@m7kvqbe1 m7kvqbe1 changed the title Migrate to pnpm Migrate to pnpm and turborepo Apr 18, 2024
@m7kvqbe1 m7kvqbe1 removed the Status: Blocked Unable to progress currently due to internal/external blocker label Apr 18, 2024
@m7kvqbe1 m7kvqbe1 moved this from Ready to In Progress in Tactical Board Apr 30, 2024
@m7kvqbe1 m7kvqbe1 mentioned this issue May 1, 2024
Merged
9 tasks
@m7kvqbe1 m7kvqbe1 changed the title Migrate to pnpm and turborepo Migrate to pnpm May 14, 2024
@m7kvqbe1 m7kvqbe1 moved this from In Progress to In Review in Tactical Board May 14, 2024
Tactical Board automation moved this from In Review to Done May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m7kvqbe1 m7kvqbe1

Labels
Size: Medium Assessed as medium task Type: Dependencies Issues that relate to a dependency Type: Techdebt Requires or will require rework
Projects
Tactical Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(Dependencies): Migrate from yarn to pnpm Royal-Navy/design-system
3 participants
@markhigham @m7kvqbe1 @jpveooys