Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(Dependencies): Migrate from yarn to pnpm #3775

Merged
merged 4 commits into from
May 14, 2024
Merged

build(Dependencies): Migrate from yarn to pnpm #3775

merged 4 commits into from
May 14, 2024

Conversation

m7kvqbe1
Copy link
Member

@m7kvqbe1 m7kvqbe1 commented May 1, 2024

Related issue

Closes #3267

Closes #3767

Overview

Migrate package manager from Yarn to Pnpm

Reason

Yarn is very old and Pnpm is now the de facto package manager.

Work carried out

  • Migrate from yarn to pnpm (change lockfile, add workspace defs)
  • Update audit script
  • Fix numerous strange type errors due to sub-dep resolution
  • Remove redundant resolutions
  • Update all GHA workflows accordingly
  • Use npx for husky lint-staged hook
  • Update yarn references in documentation and READMEs
  • Specify 18.20.1 as GHA node runtime (explicit via .nvmrc)
  • Update some GHA actions to latest (avoid node runtime version warnings)

Developer notes

Limited the scope of this change to pnpm.

Lerna has been left intact as it's used for release note generation and tagging (semantic-release under the hood).

@m7kvqbe1 m7kvqbe1 added the Type: Devops DevOps/automation related label May 1, 2024
@m7kvqbe1 m7kvqbe1 self-assigned this May 1, 2024
Copy link

netlify bot commented May 1, 2024

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
🔨 Latest commit 5f6a136
🔍 Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/664345954398e60008b37ad2
😎 Deploy Preview https://deploy-preview-3775--storybook-navy-digital-mod-uk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m7kvqbe1 m7kvqbe1 force-pushed the feat/pnpm branch 2 times, most recently from b5eb070 to dc7d608 Compare May 14, 2024 08:19
@m7kvqbe1 m7kvqbe1 marked this pull request as ready for review May 14, 2024 08:35
@m7kvqbe1 m7kvqbe1 requested a review from markhigham as a code owner May 14, 2024 08:35
@m7kvqbe1 m7kvqbe1 force-pushed the feat/pnpm branch 2 times, most recently from 3decf11 to 4f59e31 Compare May 14, 2024 09:02
@m7kvqbe1 m7kvqbe1 requested a review from elglup May 14, 2024 09:16
Copy link
Collaborator

@elglup elglup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made & tested in Netlify. All good 👍

@m7kvqbe1 m7kvqbe1 requested a review from will-lamb May 14, 2024 10:25
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@m7kvqbe1 m7kvqbe1 merged commit 0caecba into master May 14, 2024
23 checks passed
@m7kvqbe1 m7kvqbe1 deleted the feat/pnpm branch May 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Devops DevOps/automation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve node 16 GHA warnings Migrate to pnpm
3 participants