Replace uses of style prop #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpveooys
force-pushed
the
perf/remove-style-objects
branch
5 times, most recently
from
81c5c00
to
cd17194
Compare
jpveooys
changed the title
jpveooys
changed the title
jpveooys
force-pushed
the
perf/remove-style-objects
branch
from
cd17194
to
e1845e2
Compare
jpveooys
commented
Jul 11, 2022
| @@ -14,6 +14,7 @@ export const StyledSidebar = styled.aside<StyledSidebarProps>` | |||
| flex-direction: column; | |||
| position: relative; | |||
| z-index: ${zIndex('sidebar', 0)}; | |||
| flex-shrink: 0; | |||
There was a problem hiding this comment.
Removing the redundant intermediary <div> in the stories revealed this would be shrunk slightly when Sidebar is directly in SidebarWrapper, so this was added to fix that.
jpveooys
commented
Jul 11, 2022
| @@ -89,18 +95,8 @@ export const Default: ComponentStory<typeof Sidebar> = (props) => { | |||
|
|
|||
| return ( | |||
| <SidebarWrapper> | |||
| <div style={{ maxHeight: '30rem' }}> | |||
There was a problem hiding this comment.
These intermediary divs were redundant as StyledSidebar has max-height applied to it already. Removing them did reveal a small problem with the StyledSidebar styles (see comment left there).
jpveooys
commented
Jul 11, 2022
| it('is is rendered below the mouse pointer', () => { | ||
| // jest-styled-components doesn't work with css props: | ||
| // https://github.com/styled-components/jest-styled-components/issues/250 | ||
| it.skip('is is rendered below the mouse pointer', () => { |
There was a problem hiding this comment.
jest-styled-components doesn't understand css props unfortunately:
jpveooys
force-pushed
the
perf/remove-style-objects
branch
from
ad47a51
to
5b0ab49
Compare
jpveooys
commented
Jul 11, 2022
| offset: string | ||
| }) => ( | ||
| <span | ||
| className="rn_text-s" |
There was a problem hiding this comment.
There was an old CSS framework class here!
jpveooys
force-pushed
the
perf/remove-style-objects
branch
from
5b0ab49
to
8c35df1
Compare
This replaces all uses of style props in components with preferred Styled Components patterns.
This replaces all uses of style props in stories with alternative Styled Components patterns.
This stops the width of `Sidebar` being shrunk when it's placed directly in `SidebarWrapper` (causing it to be less than 60px wide).
jpveooys
force-pushed
the
perf/remove-style-objects
branch
from
8c35df1
to
1d84a3a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Resolves #2600
Overview
This replaces all uses of style props with patterns from Styled Components.
Link to preview
https://5e25c277526d380020b5e418-qvmgkmtfwt.chromatic.com/
Reason
Work carried out
Developer notes
Stories were updated as well for consistency and to make sure there are no more hits for
style=in code.