Upgrade dependencies #480
Merged
Upgrade dependencies #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyhjwb6
force-pushed
the
feature/upgrade-dependencies
branch
from
1603561
to
6c386c8
Compare
Addresses code climate warning
thyhjwb6
force-pushed
the
feature/upgrade-dependencies
branch
from
cd9a706
to
709934b
Compare
m7kvqbe1
approved these changes
Dec 10, 2019
| @@ -18,7 +18,9 @@ describe('TabSet', () => { | |||
| beforeEach(() => { | |||
| const props = { | |||
| className: 'rn-tab-set--modifier', | |||
| onChangeCallback: () => {}, | |||
| onChangeCallback: () => { | |||
| return true | |||
There was a problem hiding this comment.
I assume the empty functions here are just being used to stop it from failing loudly where a prop is required? Is this change because of a new lint rule or were these warnings?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#481
Overview
Upgrading dependencies
Note that
eslint-plugin-importhas not been upgraded due to a bug which has been fixed but not released.Change also addresses a security vulnerability in serialize-javascript.
A mistake was found in the
Buttondocumentation asonClickis not required.Reason
Security
Work carried out
Screenshot
No visual difference.
Developer notes
After making changes to
TextInputandTextArea, these components needed refactoring in order to reduce code complexity.