Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HashWriter and HashReader structs #1159

Merged
merged 3 commits into from
May 31, 2024

Conversation

joebebel
Copy link
Contributor

Not sure if this is the right place for this, but we've found frequently needing to read or write data while simultaneously hashing the data. Based on the implementation in the phase2 crate, gated by the "std" feature.

While creating this PR I noticed this previous PR which is somewhat related, but I think a little different, and I also note the documentation describes that hashers can implement io::Write, which I think is also slightly different.

@piegamesde
Copy link

I've found myself in need for this as well, multiple times. However, I wonder whether some more generic construction like a Writer broadcasting to multiple other Writers (in a separate crate) would be a better solution here.

@tarcieri tarcieri requested a review from newpavlov May 28, 2024 21:49
@newpavlov newpavlov merged commit 9136636 into RustCrypto:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants