macOS Catalyst Version #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! Thank you.
|
|
Should be good to go. @yury |
freak4pc
force-pushed
the
catalyst
branch
2 times, most recently
from
c1af11b
to
cbfc150
Compare
|
@yury Ah I actually had a PR up already, this is it :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of gotchas here:
Fabric/Crashlytics don't seem to support Catalyst as of now. Should we enable it just for iOS? Not sure if there are many other options if at all
Some colors could be nicer, for example the blue actions aren't really the best tint for dark mode, etc.
Ignore the code signing stuff and changed Bundle ID, I'll revert them a bit later.
Feel free top take this branch and run your own changes on top of it.
Thanks !