-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU: Remove unused dynamic state settings #6796
Open
sunshineinabox
wants to merge
2
commits into
Ryujinx:master
Choose a base branch
from
sunshineinabox:DynamicStateCleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
gpu
Related to Ryujinx.Graphics
graphics-backend:vulkan
Graphical bugs when using the Vulkan API
labels
May 12, 2024
AcK77
changed the title
Remove unused dynamic state settings
gpu: Remove unused dynamic state settings
May 14, 2024
AcK77
changed the title
gpu: Remove unused dynamic state settings
GPU: Remove unused dynamic state settings
May 14, 2024
gdkchan
reviewed
May 16, 2024
gdkchan
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm minus comment. This is most likely a leftover from when we didn't use dynamic state at all.
…cStateCreateInfo as the command to set them is never called. Do not pass pointer to viewport and scissor as those dynamic states should be supported on all devices. Same as above for DepthBias values.
sunshineinabox
force-pushed
the
DynamicStateCleanup
branch
from
May 23, 2024 05:22
d23ef85
to
882bb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change likely has no user facing changes, but just need to check if there is anything broken. Just clean-up for future changes.