Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Connectivity Service Secret on Kubernetes out-of-the-box (Node) #2024

Open
uwe-klinger opened this issue Jan 27, 2022 · 2 comments
Open
Labels
blocked Issues that require async communication or are blocked by external factors feature request Requests for new functionality

Comments

@uwe-klinger
Copy link

Is your feature request related to a problem? Please describe.

The Cloud SDK for Java doesn't support service credentials of the SAP BTP connectivity service (connectivity plan proxy) out-of-the-box. The documentation describes required changes that the following 3 properties (example values) need to be added:

onpremise_proxy_host: connectivity-proxy.namespace
onpremise_proxy_http_port: '20003'
url: https://xyz.authentication.xyz.hana.ondemand.com/oauth/token

Describe the solution you'd like

This approach doesn't scale for app development. Instead of this the Cloud SDK should recognize the different configuration structure and has a way to provide the onpremise_proxy_host and onpremise_proxy_port without the need to modify a generated secret. For example using environment variables or using a separate secret that can be statically setup in the application namespace without dependency to the clientid and secret that is generated by the service instance.

Describe alternatives you've considered

Current behavior

Impact / Priority

  • Makes the setup of Kubernetes deployment complicated
  • Increased effort and support

Additional context

I reported the issue for Cloud SDK Java as well: SAP/cloud-sdk#657

@tomfrenken
Copy link
Member

Hey @uwe-klinger thank you for your feedback, I think this is a very good idea and will bring it up to the team.

@marikaner marikaner added the blocked Issues that require async communication or are blocked by external factors label Jul 18, 2022
@marikaner
Copy link
Contributor

Hey @uwe-klinger, let's see whether we can manage to bring this information into the connectivity proxy by default instead of implementing a workaround. Should this not be possible, this is a great idea. We'll stay in touch on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues that require async communication or are blocked by external factors feature request Requests for new functionality
Projects
None yet
Development

No branches or pull requests

3 participants