Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Connectivity Service Secret on Kubernetes out-of-the-box (Java) #657

Closed
3 of 11 tasks
uwe-klinger opened this issue Jan 27, 2022 · 2 comments
Closed
3 of 11 tasks
Labels
Java Related to documentation on the SAP Cloud SDK for Java

Comments

@uwe-klinger
Copy link

uwe-klinger commented Jan 27, 2022

Issue Description

Important information:

The Cloud SDK for Java doesn't support service credentials of the SAP BTP connectivity service (connectivity plan proxy) out-of-the-box. The documentation describes required changes.

However, the documentation doesn't seem to be complete. The following 3 properties (example values) need to be added:

onpremise_proxy_host: connectivity-proxy.namespace
onpremise_proxy_http_port: '20003'
url: https://xyz.authentication.xyz.hana.ondemand.com/oauth/token

This approach doesn't scale for app development. Instead of this the Cloud SDK should recognize the different configuration structure and has a way to provide the onpremise_proxy_host and onpremise_proxy_http_port without the need to modify a generated secret. For example using environment variables or using a separate secret that can be statically setup in the application namespace without dependency to the clientid and secret that is generated by the service instance.

I reported the same issue for Cloud SDK Java: SAP/cloud-sdk-js#2024

Impact / Priority

  • Makes the setup of Kubernetes deployment complicated
  • Increased effort and support

Project Details

  • Link to GitHub repository: Private repository
  • Project type, for example:
    • CAP Project
    • SAP Cloud SDK Maven Archetype
    • None of the above:
  • Platform:
    • Cloud Foundry
    • Neo
    • None of the above: Kubernetes

Checklist

  • Checked out the documentation and Stack Overflow
  • Description provided with all relevant information
  • Attached debug logs
  • Attached dependency tree
  • Provided the SAP Cloud SDK version & link to relevant source code
@uwe-klinger uwe-klinger added the Java Related to documentation on the SAP Cloud SDK for Java label Jan 27, 2022
@uwe-klinger uwe-klinger changed the title Support Connectivity Service Secret on Kubernetes out-of-the-box Support Connectivity Service Secret on Kubernetes out-of-the-box (Java) Jan 27, 2022
@KavithaSiva
Copy link
Contributor

KavithaSiva commented Feb 2, 2022

@uwe-klinger thanks for your feedback, apologies for the long delay, we are discussing this within our team.

@MatKuhr
Copy link
Member

MatKuhr commented Feb 19, 2024

Sorry, I think this thread was overlooked somehow. In the meanwhile the on-premise handling on K8S changed with the release of the transparent proxy. The Cloud SDK documentation has been updated to describe how to use Cloud SDK with the transparent proxy. That way no manual adjustment of the secret should be needed anymore.

@MatKuhr MatKuhr closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Related to documentation on the SAP Cloud SDK for Java
Projects
None yet
Development

No branches or pull requests

3 participants