Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(library-reference-inquirer): adds new module @sap-ux/ui5-library-reference-inquirer #1818

Merged
merged 17 commits into from
Apr 15, 2024
Merged

feat(library-reference-inquirer): adds new module @sap-ux/ui5-library-reference-inquirer #1818

merged 17 commits into from
Apr 15, 2024

Conversation

cianmSAP
Copy link
Contributor

#1800

Adds new module @sap-ux/ui5-library-reference-inquirer

Updates project access to include utils for reading library configs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2024 •
edited

🦋 Changeset detected

Latest commit: 12704ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/inquirer-common Patch
@sap-ux/project-access Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/cap-config-writer Patch
@sap-ux/create Patch
@sap-ux/environment-check Patch
@sap-ux/preview-middleware Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP changed the title feat(library-refernence-inquirer): adds new module @sap-ux/ui5-library-reference-inquirer feat(library-reference-inquirer): adds new module @sap-ux/ui5-library-reference-inquirer Apr 10, 2024
@cianmSAP cianmSAP marked this pull request as ready for review April 10, 2024 16:12
@cianmSAP cianmSAP requested review from a team as code owners April 10, 2024 16:12
longieirl
longieirl previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the code only, didnt review all the new project files.
Changes look good.
Test coverage looks good.

devinea
devinea previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module setup looks good.
Changeset ✅
A few comments on the project access library code.

packages/project-access/src/library/helpers.ts Show resolved Hide resolved
packages/project-access/src/library/helpers.ts Outdated Show resolved Hide resolved
@cianmSAP cianmSAP dismissed stale reviews from devinea and longieirl via bcb701a April 15, 2024 11:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

devinea
devinea approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module set-up looks good.
Changeset 👍

longieirl
longieirl approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous comments apply, only reviewed the code and not the project configurations that were added.

@cianmSAP cianmSAP merged commit 98496d5 into main Apr 15, 2024
13 checks passed
@cianmSAP cianmSAP deleted the feat/1800/ref-lib-inquirer branch April 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IainSAP IainSAP IainSAP left review comments

@longieirl longieirl longieirl approved these changes

@devinea devinea devinea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cianmSAP @longieirl @devinea @IainSAP