Feat: create adt services for ui-service generation #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 73c47fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
docirl
requested review from
tobiasqueck,
cianmSAP and
slin-sap
and removed request for
cianmSAP
slin-sap
requested changes
May 3, 2024
tobiasqueck
reviewed
May 6, 2024
packages/axios-extension/src/abap/adt-catalog/services/businessobjects-service.ts
Outdated
Show resolved
Hide resolved
tobiasqueck
reviewed
May 6, 2024
packages/axios-extension/src/abap/adt-catalog/services/publish-service.ts
Outdated
Show resolved
Hide resolved
tobiasqueck
requested changes
May 6, 2024
There was a problem hiding this comment.
- tests look good and have acceptable coverage
- also tested everything manually and it worked without problems
- a few suggestions for simplifying the code
- also agree to all comments by @slin-sap
slin-sap
reviewed
May 8, 2024
tobiasqueck
approved these changes
May 8, 2024
|
slin-sap
approved these changes
May 8, 2024
|
Suggested changes have been applied. I have marked all the suggestions as resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1893