-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adp-tooling): add migration adaptation template writer #1903
feat(adp-tooling): add migration adaptation template writer #1903
Conversation
🦋 Changeset detectedLatest commit: 7bb9688 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…-update-templates
…-update-templates
…-update-templates
…-update-templates
…-update-templates
…-update-templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look as expected to support migration for webIDE created ADP projects.
Covered by tests.
changeset ✅
…-update-templates
…-update-templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change request for the test structure but the rest looks great
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changeset ok
- code clear and easy to understand
- proper test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
Thank you @tobiasqueck @devinea |
TBI - Create a separate Adaptation file writer for Migration #1901