Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adp-tooling): add migration adaptation template writer #1903

Merged

Conversation

korotkovao
Copy link
Contributor

TBI - Create a separate Adaptation file writer for Migration #1901

@korotkovao korotkovao requested a review from a team as a code owner May 7, 2024 14:31
Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 7bb9688

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/adp-tooling Minor
@sap-ux/create Patch
@sap-ux/preview-middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@korotkovao korotkovao changed the title feat(adp-tooling): add migration writer feat(adp-tooling): add migration adaptation template writer May 7, 2024
devinea
devinea previously approved these changes May 10, 2024
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look as expected to support migration for webIDE created ADP projects.
Covered by tests.
changeset ✅

Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change request for the test structure but the rest looks great

Copy link

sonarcloud bot commented May 13, 2024

Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changeset ok
  • code clear and easy to understand
  • proper test coverage

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@korotkovao
Copy link
Contributor Author

Thank you @tobiasqueck @devinea

@korotkovao korotkovao merged commit 9ccbade into main May 13, 2024
13 checks passed
@korotkovao korotkovao deleted the feat/app-migrator/migrate-adaptation-project-update-templates branch May 13, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants