-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CXSPA-2066 SSR Error Handling #18742
base: develop
Are you sure you want to change the base?
Commits on Jul 10, 2023
-
fix: 'this' is undefined in ProductEffects.productLoadEffect (#17594)
Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined. Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52) The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect` fixes https://jira.tools.sap/browse/CXSPA-3902
Configuration menu - View commit details
-
Copy full SHA for 260f4df - Browse repository at this point
Copy the full SHA 260f4dfView commit details
Commits on Jul 25, 2023
-
feat: handle http errors in ssr (#17624)
Co-authored-by: Krzysztof Platis <platonn.git@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0357962 - Browse repository at this point
Copy the full SHA 0357962View commit details
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 038ffdb - Browse repository at this point
Copy the full SHA 038ffdbView commit details
Commits on Aug 22, 2023
-
feat: created effect for handling ngrx errors (#17657)
Co-authored-by: Krzysztof Platis <platonn.git@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8bba7a6 - Browse repository at this point
Copy the full SHA 8bba7a6View commit details
Commits on Sep 27, 2023
-
Merge branch 'develop-6.5.x' into epic/ssr-error-handling
# Conflicts: # projects/core/src/product/store/actions/product-references.action.ts # projects/core/src/product/store/actions/product-reviews.action.ts # projects/core/src/product/store/effects/product-reviews.effect.ts # projects/core/src/state/utils/entity-loader/entity-loader.action.ts
Configuration menu - View commit details
-
Copy full SHA for 61f9364 - Browse repository at this point
Copy the full SHA 61f9364View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c7c665 - Browse repository at this point
Copy the full SHA 4c7c665View commit details
Commits on Sep 28, 2023
-
feat: CXSPA-3781 SSR - Multi-provided error interceptors (#17865)
This pull request introduces methodologies for integrating multiple error interceptors that manage errors within the Server-Side Rendering (SSR) framework. This architectural augmentation preserves backward compatibility, mitigating any potential disruptions for end-users upon the incorporation of new error interceptors into the system. With the introduction of this enhancement, it becomes easier for users to include new error interceptors, giving them the flexibility to determine the order in which these interceptors are applied within the system. This priority setting allows users to control how these interceptors operate and influence the workflow of the system. The order is: High priority Normal or no priority Low priority Preserves the original order within a group of interceptors with the same priority.
Configuration menu - View commit details
-
Copy full SHA for db9157b - Browse repository at this point
Copy the full SHA db9157bView commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 32d82d6 - Browse repository at this point
Copy the full SHA 32d82d6View commit details
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 77e8d8d - Browse repository at this point
Copy the full SHA 77e8d8dView commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e432c0a - Browse repository at this point
Copy the full SHA e432c0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e09980 - Browse repository at this point
Copy the full SHA 5e09980View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6074bce - Browse repository at this point
Copy the full SHA 6074bceView commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e57246 - Browse repository at this point
Copy the full SHA 0e57246View commit details
Commits on Apr 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1a2eb6e - Browse repository at this point
Copy the full SHA 1a2eb6eView commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce632d9 - Browse repository at this point
Copy the full SHA ce632d9View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f280662 - Browse repository at this point
Copy the full SHA f280662View commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for af10432 - Browse repository at this point
Copy the full SHA af10432View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1c3171a - Browse repository at this point
Copy the full SHA 1c3171aView commit details
Commits on Apr 29, 2024
-
refactor: CXSPA-6598 Remove unused error interceptors and rename MULT…
…I_ERROR_HANDLERS to singular form (#18776)
Configuration menu - View commit details
-
Copy full SHA for 293e579 - Browse repository at this point
Copy the full SHA 293e579View commit details -
feat: CXSPA-6578 Introduce PROPAGATE_SERVER_ERROR_RESPONSE and defaul…
…t ExpressJS handlers (#18753)
Configuration menu - View commit details
-
Copy full SHA for e578194 - Browse repository at this point
Copy the full SHA e578194View commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 082a459 - Browse repository at this point
Copy the full SHA 082a459View commit details