Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CXSPA-2066 SSR Error Handling #18742

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from
Draft

Commits on Jul 10, 2023

  1. fix: 'this' is undefined in ProductEffects.productLoadEffect (#17594)

    Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined.
    
    Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52)
    
    The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect`
    
    fixes https://jira.tools.sap/browse/CXSPA-3902
    Platonn authored and kpawelczak committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    260f4df View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. feat: handle http errors in ssr (#17624)

    Co-authored-by: Krzysztof Platis <platonn.git@gmail.com>
    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    3 people committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0357962 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    038ffdb View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. feat: created effect for handling ngrx errors (#17657)

    Co-authored-by: Krzysztof Platis <platonn.git@gmail.com>
    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    3 people committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8bba7a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge branch 'develop-6.5.x' into epic/ssr-error-handling

    # Conflicts:
    #	projects/core/src/product/store/actions/product-references.action.ts
    #	projects/core/src/product/store/actions/product-reviews.action.ts
    #	projects/core/src/product/store/effects/product-reviews.effect.ts
    #	projects/core/src/state/utils/entity-loader/entity-loader.action.ts
    kpawelczak committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    61f9364 View commit details
    Browse the repository at this point in the history
  2. Unit test fixes (#17879)

    kpawelczak committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    4c7c665 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. feat: CXSPA-3781 SSR - Multi-provided error interceptors (#17865)

    This pull request introduces methodologies for integrating multiple error interceptors that manage errors within the Server-Side Rendering (SSR) framework. This architectural augmentation preserves backward compatibility, mitigating any potential disruptions for end-users upon the incorporation of new error interceptors into the system.
    
    With the introduction of this enhancement, it becomes easier for users to include new error interceptors, giving them the flexibility to determine the order in which these interceptors are applied within the system. This priority setting allows users to control how these interceptors operate and influence the workflow of the system.
    
    The order is:
    High priority
    Normal or no priority
    Low priority
    
    Preserves the original order within a group of interceptors with the same priority.
    pawelfras committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    db9157b View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    32d82d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. fix build failure (#17944)

    kpawelczak committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    77e8d8d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    e432c0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e09980 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. remove test.json files

    pawelfras committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6074bce View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    0e57246 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. chore: cleanup

    pawelfras committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1a2eb6e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    ce632d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    f280662 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    af10432 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    1c3171a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. refactor: CXSPA-6598 Remove unused error interceptors and rename MULT…

    …I_ERROR_HANDLERS to singular form (#18776)
    pawelfras committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    293e579 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e578194 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    082a459 View commit details
    Browse the repository at this point in the history