Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused and deprecated styling #9839

Merged
merged 1 commit into from
Nov 18, 2020
Merged

fix: remove unused and deprecated styling #9839

merged 1 commit into from
Nov 18, 2020

Conversation

tobi-or-not-tobi
Copy link
Contributor

fixes #8498

@cypress
Copy link

cypress bot commented Nov 18, 2020


Test summary

37 • 0 • 0 • 0

Run details
Project spartacus
Status Passed
Commit 91de426e37 ℹ️
Started Nov 18, 2020 8:51 AM
Ended Nov 18, 2020 8:54 AM
Duration 02:40 💡
OS Linux Ubuntu - 18.04
Browser Electron 83

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mirkosoft mirkosoft self-requested a review November 18, 2020 09:07
mirkosoft
mirkosoft approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@mirkosoft mirkosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App builds up fine and runs without any errors.

@tobi-or-not-tobi tobi-or-not-tobi merged commit 5e96872 into develop Nov 18, 2020
@tobi-or-not-tobi tobi-or-not-tobi deleted the feature/GH-8498 branch November 18, 2020 09:23
Matejk00 added a commit that referenced this pull request Nov 18, 2020
@Matejk00
GH-9839: add missing mentions to migration doc
9e8ab38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkosoft mirkosoft mirkosoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the bootstrap mixin dependency
2 participants
@tobi-or-not-tobi @mirkosoft