Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handling of "not found" resources in READ operations #518

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

lechnerc77
Copy link
Member

@lechnerc77 lechnerc77 commented Nov 8, 2023

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
- Create resources via Terraform
- Manually remove the resources in the BTP cockpit
- Re-executing a terraform plan

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • Missing resources trigger a recreation without manual intervention by the caller

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 8, 2023
@lechnerc77 lechnerc77 added this to the 1.0.0-rc1 milestone Nov 8, 2023
@lechnerc77 lechnerc77 self-assigned this Nov 8, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) November 8, 2023 12:32
@lechnerc77
Copy link
Member Author

Sonar Cloud fails due to aforementioned limitation concerning the testability. Overall test coverage will not be decreased, so the failed check can be ignored

@lechnerc77 lechnerc77 merged commit 376e3da into main Nov 8, 2023
14 of 15 checks passed
@lechnerc77 lechnerc77 deleted the issue-514 branch November 8, 2023 13:50
@lechnerc77 lechnerc77 modified the milestones: 1.0.0-rc1, 0.6.0-beta2 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Handling of removed resources in READ
2 participants