Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fix for issue 819 #820

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: bug fix for issue 819 #820

merged 1 commit into from
May 16, 2024

Conversation

CHERIANS
Copy link
Contributor

@CHERIANS CHERIANS commented May 14, 2024

Purpose

This fix makes region, subdomain and id as computed

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Resolved #819

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@CHERIANS CHERIANS added the do-not-merge Do not merge PR (e.g. due to release preparation) label May 14, 2024
@CHERIANS CHERIANS added this to the 1.4.0 milestone May 14, 2024
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vipinvkmenon vipinvkmenon removed the do-not-merge Do not merge PR (e.g. due to release preparation) label May 16, 2024
@vipinvkmenon vipinvkmenon merged commit 2cd1a68 into main May 16, 2024
19 checks passed
@vipinvkmenon vipinvkmenon deleted the bug-819 branch May 16, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Terraform sample for DC mission 4024 fails
3 participants