fix: replace node-fetch with axios #434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use axios instead of note-fetch to better support proxy "re #285"
|
Jakob seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
use axios instead of note-fetch to better support proxy impemen https over http proxy support and fetch proxy settings from NPM "re #285"
fix: replace node-fetch with axios
|
This pull request introduces 1 alert when merging b1cb1e2 into e37d52c - view on LGTM.com new alerts:
|
use axios instead of note-fetch to better support proxy impemen https over http proxy support and fetch proxy settings from NPM "re #285"
fix: replace node-fetch with axios
|
This pull request introduces 1 alert when merging d3bbb89 into e37d52c - view on LGTM.com new alerts:
|
|
I've committed some code with another user appearantly. All tests are passing now, however they fail intermitently when running via the ci script. I think my node is struggling with the parallel processes. Would be good if you could take a look |
|
found a better solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use axios instead of note-fetch to better support proxy
"re #285"