Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid type conversion #578

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

fix: avoid type conversion #578

wants to merge 17 commits into from

Conversation

marufrasully
Copy link
Contributor

No description provided.

@vadson71
Copy link
Contributor

vadson71 commented Apr 3, 2023

@mr25mr Please add change set

MN-public and others added 15 commits April 3, 2023 12:15
@MN-public @marufrasully
Update README.md (#577)
296b655 
* Update README.md

Add section: Enabling offline work

* Update README.md

updated formatting
When configuring local web server, make sure it responds to the exact UI5 version defined in manifest.json e.g `<your.local.web.server>/1.111.0`
**Note**: Once online, UI5 Language Assistant also caches required resources for offline usage and performance optimization.

* fix: format

---------

Co-authored-by: Maruf Rasully <maruf.rasully@sap.com>
@vadson71 @marufrasully
feat: migration to github actions (#575)
f33022f 
* feat: migration to github actions

* feat: npm deploy enabled
@marufrasully
chore: apply latest changesets
6cb3695
@marufrasully @vadson71
fix: replace webpack with esbuild which solved crashing (#581)
7954265 
* fix: replace webpack with esbuild which solved crashing

* fix: changeset is added and minor corrections

* fix: esbuild scripts optimization

* fix: enable github action build job for pull requests

* fix: change set update

* fix: fixed server crash with trace log level, node version update for esbuild

* fix: webpack configs removed

---------

Co-authored-by: Vadim Koblov <vadims.koblovs@sap.com>
@marufrasully
chore: apply latest changesets
12f56fb
@vadson71 @marufrasully
feat: version bump for the offline mode related packages (#583)
eca8568
@vadson71 @marufrasully
fix: central changelog deleted (#584)
dff56c8
@marufrasully
chore: apply latest changesets
2493eb7
@vadson71 @marufrasully
fix: npm publish fix (#585)
4b49ac2
@marufrasully
chore: apply latest changesets
bc79954
@vadson71 @marufrasully
fix: environment for publishing (#587)
2b810e6
@marufrasully
chore: add changeset
4d32a8a
@marufrasully
Merge branch 'master' into type-conversion
40d85ef
@marufrasully
Update modern-hats-admire.md
1426e2c
@marufrasully
Update modern-hats-admire.md
81542b5
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vadson71
Copy link
Contributor

vadson71 commented Apr 3, 2023

Changes look reasonable to me

@cla-assistant
Copy link

cla-assistant bot commented Oct 18, 2023 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ marufrasully
✅ vadson71
❌ voicis
❌ MN-public
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant
Copy link

cla-assistant bot commented Oct 18, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

❌ MN-public
❌ voicis
❌ mr25mr
❌ vadson71
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadson71 vadson71 vadson71 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marufrasully @vadson71 @voicis @MN-public